feat: support limit to last feature #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
added
api: firestore
googlebot
added
the
cla: yes
IlyaFaer
commented
Jun 4, 2020
|
Should we add a system test for this feature? |
|
@crwilcox I'll defer to you on the python code change. |
crwilcox
suggested changes
Jun 11, 2020
crwilcox
reviewed
Jun 15, 2020
crwilcox
reviewed
Jun 16, 2020
There was a problem hiding this comment.
A few comment/docs requests, but leaving it up to @crwilcox for approval and merge.
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
|
@IlyaFaer @BenWhitehead I think we may want this in before releasing 1.8.0 |
|
Yeah, we definitely want this pre v2 |
crwilcox
approved these changes
Jun 26, 2020
|
Thanks for the updated comments. Merging. |
rafilong
added a commit
to rafilong/python-firestore
that referenced
this pull request
Aug 6, 2020
rafilong
added a commit
that referenced
this pull request
Aug 7, 2020
* feat: integrate limit_to_last changes from #57 to async * fix: whitespace in docs * fix: whitespace in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing an implementation with de-deprecation of the
get()method (as @BenWhitehead mentioned).