Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: strip proto wrappers in '_helpers.decode_{value,dict}' #458

Merged
merged 2 commits into from Sep 23, 2021
Merged

perf: strip proto wrappers in '_helpers.decode_{value,dict}' #458

merged 2 commits into from Sep 23, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 23, 2021

Closes #351.

@tseaver tseaver requested a review from a team as a code owner September 23, 2021 20:17
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@tseaver tseaver mentioned this pull request Sep 23, 2021
Closed
@crwilcox crwilcox merged commit 335e2c4 into main Sep 23, 2021
@crwilcox crwilcox deleted the 351-perf-avoid-proto-plus-penalty branch September 23, 2021 20:32
@tseaver tseaver mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetching a document takes very long when it has a large map with a large index
2 participants
@tseaver @crwilcox