Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat None cursors as a no-op. #440

Merged
merged 4 commits into from Sep 2, 2021
Merged

fix: treat None cursors as a no-op. #440

merged 4 commits into from Sep 2, 2021

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Sep 1, 2021

fixes #439

@crwilcox crwilcox requested a review from a team September 1, 2021 21:50
@crwilcox crwilcox requested a review from a team as a code owner September 1, 2021 21:50
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021
@leahecole
Copy link

LGTM from python owners point of view though a storage-y person should maybe glance at it as well

@crwilcox crwilcox merged commit e7aed0f into googleapis:main Sep 2, 2021
@crwilcox crwilcox deleted the fix-439 branch September 2, 2021 15:44
@tseaver tseaver mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start_after(None) and the like should be a no-op and shouldn't result in an error
3 participants
@crwilcox @leahecole @tseaver