fix: reseed for each auto id on 3.6 to avoid collisions #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
crwilcox
force-pushed
the
fix-seed-collisions
branch
from
21008ef
to
6524b10
Compare
tseaver
suggested changes
Jul 6, 2021
crwilcox
changed the title
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
craiglabenz
approved these changes
Jul 7, 2021
tseaver
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346 🦕
Upon further investigation, this is only an issue for python 3.6. In 2022, when 3.6 is no longer supported, this patch could be removed.