Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow underspecifying a cursor #340

Merged
merged 6 commits into from Apr 26, 2021
Merged

fix: Allow underspecifying a cursor #340

merged 6 commits into from Apr 26, 2021

Conversation

crwilcox
Copy link
Contributor

Draft to help show where Python differs w.r.t cursors, orderby

Fixes #339 馃

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Apr 23, 2021
@crwilcox crwilcox changed the title fix: in progress fix, allow less cursor than order by fix: Allow underspecifying a cursor Apr 26, 2021
@crwilcox crwilcox marked this pull request as ready for review April 26, 2021 20:14
@crwilcox crwilcox requested a review from a team April 26, 2021 20:14
@crwilcox crwilcox requested a review from a team as a code owner April 26, 2021 20:14
craiglabenz
craiglabenz approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2021
@crwilcox crwilcox merged commit abe9e8a into googleapis:master Apr 26, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request May 3, 2021
@release-please
chore: release 2.1.1 (#341)
ee518b7 
馃 I have created a release \*beep\* \*boop\*
---
### [2.1.1](https://www.github.com/googleapis/python-firestore/compare/v2.1.0...v2.1.1) (2021-05-03)


### Bug Fixes

* Allow underspecifying a cursor ([#340](https://www.github.com/googleapis/python-firestore/issues/340)) ([abe9e8a](https://www.github.com/googleapis/python-firestore/commit/abe9e8ab66ba55e43ae7da9e7d9febd1e63a5183))
* bump minimum versions for google-api-core and proto-plus ([#334](https://www.github.com/googleapis/python-firestore/issues/334)) ([08554dc](https://www.github.com/googleapis/python-firestore/commit/08554dc803a59f7ecd2310ce6860ed4f8aacf78d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiglabenz craiglabenz craiglabenz approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library raises when fewer cursors than order by clauses
4 participants
@crwilcox @craiglabenz @schmidt-sebastian @yoshi-kokoro