feat(firestore): add v1beta1 deprecation annotation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…c/python-firestore into deprecation_v1beta1_proto
…c/python-firestore into deprecation_v1beta1_proto
mf2199
changed the title
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
requested review from
BenWhitehead
and removed request for
lukesneeringer
|
@crwilcox Can you take a look at this and review it for the correct way to annotating the v1beta1 protos as deprecated? |
crwilcox
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'v1beta1' deprecation annotation added to
__init__.py, following the scheme from Bigtable and a related, already merged deprecation PR #8886.A note on Kokoro failure: The error traces to a docstring inside
/google/cloud/firestore_v1/types.pyfile, which was unaffected by the proposed changes.