Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot method for async collections #301

Closed
Kyzegs opened this issue Feb 3, 2021 · 2 comments
Closed

Snapshot method for async collections #301

Kyzegs opened this issue Feb 3, 2021 · 2 comments
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@Kyzegs
Copy link

Kyzegs commented Feb 3, 2021

Is there a reason why the async collections do not have on_snapshot? And are there any plans to add this?

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Feb 3, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 4, 2021
@dmahugh dmahugh added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Feb 8, 2021
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 8, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 8, 2021
@tseaver
Copy link
Contributor

tseaver commented Nov 15, 2021

@Kyzegs You ask a good question. I believe that the design of Collection.on_snapshot / Query.on_snapshot (start a background thread which invokes a callback thread "forever" or until cancelled) wasn't seen as a great fit for the current async pattern: in the async world, one would likely expect instead to have an async method which yielded the "snapshot" objects (sets of added / updated / removed / deleted documents).

@tseaver
Copy link
Contributor

tseaver commented Dec 1, 2021

Note that adding async support for the Watch mechanism is an existing feature request: #131

@tseaver tseaver closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

5 participants