Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct type hint for '*path' args #300

Merged
merged 2 commits into from Feb 4, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 2, 2021

PEP 484 specifies that they be hinted as the type of a single element,
as seen from the caller's perspective.

Closes #289.

PEP 484 specifies that they be hinted as the type of a single element,
as seen from the caller's perspective.

Closes #289.
@tseaver tseaver requested review from craiglabenz, dmahugh and a team February 2, 2021 22:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Feb 2, 2021
@tseaver tseaver mentioned this pull request Feb 3, 2021
4 tasks
@crwilcox crwilcox merged commit 15b579f into master Feb 4, 2021
@crwilcox crwilcox deleted the 289-fix_typing_for_path_args branch February 4, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type hints in collection()
2 participants