fix: patch emulator channel to be created accordingly #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
lidizheng
force-pushed
the
patch-emulator-channel
branch
from
5b7990b
to
e3bbb2f
Compare
lidizheng
changed the title
lidizheng
force-pushed
the
patch-emulator-channel
branch
from
f90bda8
to
e152dcb
Compare
crwilcox
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/python-api-core#124 or #286.
The behavior that, while using emulator, the AsyncIO API will hang is caused by the workaround of using a more tolerant credentials. Emulator is ran locally without SSL protection, so normal credentials won't work. This PR is a temporary fix that allows the emulator channel to adapt corresponding transport class.
The most ideal fix could go like:
google-auth, or have a more flexible credentials class allowing replace channel credentials;python-api-corerepo to handle consumption of credentials in thecreate_channelfunction.However, for a foreseeable future, current patch should work fine.