Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit data transferred as part of list_documents as we don't require field data #280

Merged
merged 3 commits into from Dec 16, 2020
Merged

fix: limit data transferred as part of list_documents as we don't require field data #280

merged 3 commits into from Dec 16, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 16, 2020 •
edited

As we don't use any of the field data as part of list_documents, we can exclude it from the request/wire :)

Fixes #5 🦕

@crwilcox crwilcox requested a review from a team December 16, 2020 17:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 16, 2020
schmidt-sebastian
schmidt-sebastian approved these changes Dec 16, 2020
View reviewed changes
Copy link

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches https://github.com/googleapis/nodejs-firestore/blob/3cd29d22073cff8d0ca072057c63dfe0a2144841/dev/src/reference.ts#L2436

@crwilcox crwilcox merged commit 0386bc4 into googleapis:master Dec 16, 2020
@crwilcox crwilcox deleted the limit-data-xfer-list-documents branch December 16, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore: coll_ref.list_documents() retrieves complete documents first, then returns doc_refs?
3 participants
@crwilcox @BenWhitehead @schmidt-sebastian