Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support using client credentials with emulator #269

Merged
merged 4 commits into from Dec 14, 2020

Conversation

paulharter
Copy link
Contributor

This changes the grpc.Channel used when connecting to a local emulator so that the client credentials are used. This allows for testing database rules against the emulator in python.

Fixes ##268

thanks

@paulharter paulharter requested a review from a team December 9, 2020 12:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 9, 2020
@BenWhitehead BenWhitehead added the semver: minor A new feature was added. No breaking changes. label Dec 10, 2020
@BenWhitehead
Copy link
Collaborator

This seems like a convenient thing to have, what do you think @crwilcox ?

@crwilcox crwilcox changed the title Using client credentials with emulator feat: support using client credentials with emulator Dec 10, 2020
@crwilcox crwilcox added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 10, 2020
@crwilcox
Copy link
Contributor

Thanks for the contribution @paulharter. In order for us to accept this we would need it to pass linting and coverage. The linting can be fixed by running nox -s blacken and verifying with nox -s lint. If you look at the kokoro build you will see what lines weren't covered, google/cloud/firestore_v1/base_client.py 151 7 38 0 96% 178-199

@paulharter
Copy link
Contributor Author

@crwilcox I've added a test and linted, I hope it's ok now.

Thank you for accepting this, it will make testing much easier.

@crwilcox crwilcox added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 12, 2020
@crwilcox crwilcox merged commit dffc580 into googleapis:master Dec 14, 2020
@crwilcox
Copy link
Contributor

Thanks for the contribution @paulharter. This will go out in the next minor release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. semver: minor A new feature was added. No breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants