Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python-Firestore API Documentation #262

Closed
martindufort opened this issue Nov 26, 2020 · 8 comments · Fixed by #263
Closed

Python-Firestore API Documentation #262

martindufort opened this issue Nov 26, 2020 · 8 comments · Fixed by #263
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.

Comments

@martindufort
Copy link

Hi,

We are currently integrating Cloud Firestore (using the Python client) into one of our project.

However we have some difficulties grasping all the capabilities because it seems the API documentation here is incomplete.

I have to resort to browsing the GitHub source code to grasp which methods are available to perform a specific behavior.

Example: In the API Documentation there is no reference to class DocumentSnapshot I could find.

Some of the questions, I was asking myself:
How do I get a DocumentReference from a DocumentSnapshot instance ?

I had to browse the class DocumentSnapshot source code and find that the property reference was available for that.

Let me know if I'm not looking at the proper location.
Thanks for your support.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 26, 2020
@HemangChothani HemangChothani added the documentation Improvements or additions to documentation label Nov 27, 2020
@HemangChothani HemangChothani self-assigned this Nov 27, 2020
@HemangChothani HemangChothani added the type: docs Improvement to the documentation for an API. label Nov 27, 2020
@martindufort
Copy link
Author

Is the public documentation web page now reflecting all classes ?

@HemangChothani
Copy link
Contributor

Yes, i think only DocumentSnapshot class was missing.

@tseaver
Copy link
Contributor

tseaver commented Dec 15, 2020

Nope. Please see 9fdad0c (part of PR #279) for other cases where the "async split" left classes undocumented.

@martindufort
Copy link
Author

I'm looking here https://googleapis.dev/python/firestore/latest/document.html and I don't see DocumentSnaphot documentation.

@HemangChothani
Copy link
Contributor

@martindufort DocumentSnaphot is added in #263 PR, waiting for merge.

@HemangChothani
Copy link
Contributor

@tseaver I was not aware about exposing the documentation of async classes.

@martindufort
Copy link
Author

@martindufort DocumentSnaphot is added in #263 PR, waiting for merge.

Any timeline in closing this PR ?

@1337SEnergy
Copy link

1337SEnergy commented Jan 28, 2021

there seems to be many more issues with the documentation, for example the documentation for DocumentChange says there are document, target_ids and removed_target_ids fields, however from my inspection there are document, old_index, new_index and type fields instead...

as mentioned by @martindufort, I have to rely on code inspection to fully grasp how this library actually works, as the documentation is of very little help and in a lot of cases seems outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. documentation Improvements or additions to documentation type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants