Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update intersphinx for grpc and auth #261

Merged
merged 3 commits into from Jan 28, 2021
Merged

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Nov 19, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/0f62eaec-2bc9-495b-ad40-7e8c1fdf3554/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@a073c87
Source-Link: googleapis/synthtool@9a7d9fb

@yoshi-automation yoshi-automation requested a review from a team November 19, 2020 14:47
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@tseaver tseaver changed the title docs(python): update intersphinx for grpc and auth docs: update intersphinx for grpc and auth Nov 24, 2020
tseaver
tseaver previously approved these changes Nov 24, 2020
docs/conf.py Outdated
"google-auth": ("https://google-auth.readthedocs.io/en/stable", None),
"python": ("https://python.readthedocs.org/en/latest/", None),
"google-auth": (
"https://googleapis.dev/python/google-auth/latest/index.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks the docs build.This is supposed to be the directory from which objects.inv can be fetched.

Suggested change
"https://googleapis.dev/python/google-auth/latest/index.html",
"https://googleapis.dev/python/google-auth/latest/",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the "regenerate this PR" box. Let's see how that goes.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 24, 2020
* docs(python): update intersphinx for grpc and auth

* use https for python intersphinx

Co-authored-by: Tim Swast <swast@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Nov 18 14:37:25 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9
Source-Link: googleapis/synthtool@9a7d9fb
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu Nov 19 10:16:05 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: a073c873f3928c561bdf87fdfbf1d081d1998984
Source-Link: googleapis/synthtool@a073c87
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 25, 2020
Copy link
Contributor

@craiglabenz craiglabenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craiglabenz craiglabenz merged commit 1bbd3a0 into master Jan 28, 2021
@craiglabenz craiglabenz deleted the autosynth-synthtool branch January 28, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants