Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort exceptions properly (manual synth) #256

Merged
merged 1 commit into from Nov 13, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 12, 2020

I'm hoping that a manual synth will get the hashes in synth.metadata updated all at once, so that future "self" and "synthtoolls" autosynth runs can use the current latest version of googleapis.

  • Restore path helper methods to generated clients.
  • Enforce that 'request' argument to generated client methods is exclusive
    to flattened arguments.
  • Surface 'transport' property for generated clients.

Closes #251
Closes #252

- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
@tseaver tseaver requested review from crwilcox, busunkim96 and a team November 12, 2020 23:58
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@tseaver
Copy link
Contributor Author

tseaver commented Nov 13, 2020

@crwilcox, @czahedi looks like @busunkim96 can't approve-for-merge here, either (requiresCodeOwnerReviews: true only allows members of @googleapis/firestore-dpe, looks like).

@crwilcox
Copy link
Contributor

@tseaver this description seems inaccurate. Since you have reviewed fully can you describe the changes this is making (it doesn't seem to be about exception order)

@tseaver
Copy link
Contributor Author

tseaver commented Nov 13, 2020

@crwilcox The main point of this PR is to do a full manual synth, trying to get around the fact that the three autosynth PRs can revert to older hashes for (especially, right now) googleapis.

The symptom of that reversion is that the self and synthtools builds are generating using gapic-generator-python 0.33.2, which has the bug of scrambling exception order (see #251, #253).

The rest of the changes (adding path helper methods, transport, etc.) are detailed in the commit description.

@crwilcox crwilcox merged commit 386e85e into master Nov 13, 2020
@tseaver tseaver deleted the 251-252-manual-synth branch November 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants