Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore path helper methods to generated clients #252

Closed
wants to merge 7 commits into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/68aaa8af-44b6-4920-b7df-7f4478f1e87b/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 339292950
Source-Link: googleapis/googleapis@07d41a7
PiperOrigin-RevId: 339261149
Source-Link: googleapis/googleapis@c9d7721
PiperOrigin-RevId: 339152802
Source-Link: googleapis/googleapis@b3c2eb0
PiperOrigin-RevId: 339048690
Source-Link: googleapis/googleapis@3c8c2d8
PiperOrigin-RevId: 338646463
Source-Link: googleapis/googleapis@20b11df
PiperOrigin-RevId: 338561467
Source-Link: googleapis/googleapis@7391e77

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
PiperOrigin-RevId: 338561467

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Oct 22 15:29:48 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 7391e775fd3620c1306b9677bfbcf6221d42f3c3
Source-Link: googleapis/googleapis@7391e77
PiperOrigin-RevId: 338646463

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Oct 23 03:57:15 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 20b11dfe4538cd5da7b4c3dd7d2bf5b9922ff3ed
Source-Link: googleapis/googleapis@20b11df
BREAKING CHANGE: update package names to avoid conflict with google-cloud-bigquery

The google-cloud-bigquery package uses the `google.cloud.bigquery` path as a
plain Python module, not a namespace package. When this package and
google-cloud-bigquery are installed in the same environment, conflicts can
result.

PiperOrigin-RevId: 339048690

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Oct 26 09:00:37 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 3c8c2d81369c4665824b20706426b018507415f7
Source-Link: googleapis/googleapis@3c8c2d8
PiperOrigin-RevId: 339152802

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Oct 26 17:26:54 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: b3c2eb02e501d7eec36b4b08fcd981f32f8b4ff4
Source-Link: googleapis/googleapis@b3c2eb0
PiperOrigin-RevId: 339261149

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Oct 27 09:09:14 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c9d7721bd4e22b3a25d914248fac126a5a91d3d9
Source-Link: googleapis/googleapis@c9d7721
PiperOrigin-RevId: 339292950

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Oct 27 11:32:46 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 07d41a7e5cade45aba6f0d277c89722b48f2c956
Source-Link: googleapis/googleapis@07d41a7
@yoshi-automation yoshi-automation requested a review from a team November 11, 2020 14:11
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Nov 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@tseaver tseaver changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. chore: restore path helper methods to generated clients Nov 12, 2020
tseaver
tseaver previously approved these changes Nov 12, 2020
DEFAULT_PYTHON_VERSION = "3.8"
SYSTEM_TEST_PYTHON_VERSIONS = ["3.7"]
UNIT_TEST_PYTHON_VERSIONS = ["3.6", "3.7", "3.8"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting @crwilcox from PR #251

Look into updating noxfile template.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update should be in synthtool, next gen should have this.

@tseaver tseaver dismissed their stale review November 12, 2020 21:24

Inadvertent: just meant to comment

@tseaver tseaver mentioned this pull request Nov 12, 2020
1 task
tseaver added a commit that referenced this pull request Nov 12, 2020
- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2020
crwilcox pushed a commit that referenced this pull request Nov 13, 2020
… generated layer (#256)

- Restore path helper methods to generated clients.
- Enforce that 'request' argument to generated client methods is exclusive
  to flattened arguments.
- Surface 'transport' property for generated clients.

Closes #251
Closes #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement. context: partial do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants