Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port query retry from Node, Java to Python #223

Closed
crwilcox opened this issue Oct 20, 2020 · 0 comments · Fixed by #456
Closed

Port query retry from Node, Java to Python #223

crwilcox opened this issue Oct 20, 2020 · 0 comments · Fixed by #456
Assignees
@tseaver
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

To harden queries, we can restart a stream with the last received document as the cursor

Node Implementation: googleapis/nodejs-firestore#1116
Java Implementation: googleapis/java-firestore#426
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 20, 2020
@crwilcox crwilcox added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 20, 2020
@tseaver tseaver self-assigned this Sep 23, 2021
tseaver added a commit that referenced this issue Sep 23, 2021
@tseaver
fix: harden 'query.stream' against retriable exceptions
40f8aba 
Closes #223.
@tseaver tseaver mentioned this issue Sep 23, 2021
Merged
tseaver added a commit that referenced this issue Sep 23, 2021
@tseaver
fix: harden 'query.stream' against retriable exceptions (#456)
0dca32f 
Closes #223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: harden 'query.stream' against retriable exceptions googleapis/python-firestore
2 participants
@tseaver @crwilcox