Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-language conformance tests to latest spec #217

Closed
2 tasks
tseaver opened this issue Oct 7, 2020 · 0 comments · Fixed by #219
Closed
2 tasks

Update cross-language conformance tests to latest spec #217

tseaver opened this issue Oct 7, 2020 · 0 comments · Fixed by #219
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 7, 2020

PR #205 re-enabled the tests/unit/v1/test_cross_language.py test suite, but did not pull in the latest versions of the conformance test data files, specifically using the new update_transform feature.

To do:

  • Run make -f Makefile_v1 copy-testdata. Verify that tests of updates fail.
  • Update explicit unit tests and code for update-related methods to bundle values previously packed into separate transform messages into the update_transforms sub-message of the update message. Verify that conftests now pass.
@tseaver tseaver added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 7, 2020
@tseaver tseaver self-assigned this Oct 7, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 7, 2020
tseaver added a commit that referenced this issue Oct 7, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 10, 2020
Update `pbs_for_create`, `pbs_for_set_no_merge`, `pbs_for_set_with_merge`, and `pbs_for_update` to match semantics expected by current versions of [conformance tests](googleapis/conformance-tests@0bb8520):

- Rather than create separate `Write.transform` messages to hold field transforms, inline them as `update_transforms` in the main `Write.update` message (which will always be created now).

Copy in the current version of the conftest JSON files and verify.

Closes #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant