Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: harden version data gathering against DistributionNotFound #212

Merged
merged 2 commits into from Oct 6, 2020
Merged

fix: harden version data gathering against DistributionNotFound #212

merged 2 commits into from Oct 6, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Oct 6, 2020

No description provided.

@crwilcox crwilcox requested a review from a team October 6, 2020 19:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
@crwilcox crwilcox requested a review from tseaver October 6, 2020 19:37
@tseaver
Copy link
Contributor

tseaver commented Oct 6, 2020

I'm not in firestore-dpe, and so my approval doesn't count. :(

@dmahugh dmahugh self-requested a review October 6, 2020 20:44
BenWhitehead
BenWhitehead approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stampystamp:

@crwilcox crwilcox merged commit 20b7260 into googleapis:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@dmahugh dmahugh Awaiting requested review from dmahugh

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crwilcox @tseaver @BenWhitehead