Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partition queries #210

Merged
merged 2 commits into from Oct 6, 2020

Conversation

chrisrossi
Copy link
Contributor

@chrisrossi chrisrossi commented Oct 2, 2020

Implement the new partition queries feature for Firestore.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

constraints of the query that produced this partition.

Args:
query (BaseQuery): The original query that is a partition of.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original query that this is a partition of?

the beginning of the result set.
end_at (Optional[~google.cloud.firestore_v1.document.DocumentSnapshot]):
Cursor for first query result after the last result included in the
partition. If `None`, the partitions runs to the end of the result set.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/partitions/partition/

google/cloud/firestore_v1/query.py Outdated Show resolved Hide resolved
Implement the new partition queries feature for Firestore.
@chrisrossi chrisrossi changed the title WIP: Partition queries feat: partition queries Oct 5, 2020
@chrisrossi chrisrossi merged commit 4f75a75 into googleapis:master Oct 6, 2020
@chrisrossi chrisrossi deleted the feat-partition-query branch October 6, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants