Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more Python sequence types when encoding to Protobuf #21

Merged

Conversation

hongquan
Copy link
Contributor

@hongquan hongquan commented Feb 20, 2020

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #20 🦕

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 20, 2020
@hongquan
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 20, 2020
@hongquan hongquan force-pushed the feature/encode-more-sequence-type branch from b621bea to ab94ed5 Compare February 20, 2020 07:13
@hongquan hongquan force-pushed the feature/encode-more-sequence-type branch from ab94ed5 to 3cb7eb3 Compare February 20, 2020 07:15
@hongquan
Copy link
Contributor Author

@BenWhitehead Could you please review?

@BenWhitehead
Copy link
Collaborator

@tseaver or @crwilcox Can either of you take a look at this and provide a review? This seems useful to me, but I'm not able to evaluate the code change toward the goal.

@crwilcox crwilcox changed the title Support more Python sequence types when encoding to Protobuf feat: support more Python sequence types when encoding to Protobuf May 29, 2020
@crwilcox crwilcox added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@crwilcox
Copy link
Contributor

@hongquan would mind pulling in the upstream master and pushing again?

@hongquan
Copy link
Contributor Author

@crwilcox I've just updated.

@crwilcox crwilcox added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 29, 2020
@crwilcox crwilcox merged commit b1c5987 into googleapis:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tuple when encoding to Firestore value
5 participants