Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for != and not-in queries #189

Closed
HemangChothani opened this issue Sep 17, 2020 · 2 comments · Fixed by #202
Closed

Add support for != and not-in queries #189

HemangChothani opened this issue Sep 17, 2020 · 2 comments · Fixed by #202
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@HemangChothani
Copy link
Contributor

Porting from Java and Node

For python auto generated code is missing here whereas it's generated for java.

class Operator(proto.Enum):
r"""A field filter operator."""
OPERATOR_UNSPECIFIED = 0
LESS_THAN = 1
LESS_THAN_OR_EQUAL = 2
GREATER_THAN = 3
GREATER_THAN_OR_EQUAL = 4
EQUAL = 5
ARRAY_CONTAINS = 7
IN = 8
ARRAY_CONTAINS_ANY = 9

@tseaver @crwilcox Should i run synth.py for that?

@HemangChothani HemangChothani added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 17, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 17, 2020
@HemangChothani HemangChothani self-assigned this Sep 17, 2020
@HemangChothani
Copy link
Contributor Author

Found the PR of auto generated code #171 and it's blocked for now.

@tseaver
Copy link
Contributor

tseaver commented Sep 21, 2020

PR #187 replaced PR #171. It added NOT_EQUAL and NOT_IN:

        class Operator(proto.Enum):
            r"""A field filter operator."""
            OPERATOR_UNSPECIFIED = 0
            LESS_THAN = 1
            LESS_THAN_OR_EQUAL = 2
            GREATER_THAN = 3
            GREATER_THAN_OR_EQUAL = 4
            EQUAL = 5
            NOT_EQUAL = 6
            ARRAY_CONTAINS = 7
            IN = 8
            ARRAY_CONTAINS_ANY = 9
            NOT_IN = 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants