Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use specific naming convention #169

Merged
merged 2 commits into from Sep 1, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards #56
From the comment of PR #58 (comment)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2020
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 22, 2020
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HemangChothani Please rebase / retarget your changes against the current master branch. The v2-staging branch is no longer active (@crwilcox force-pushed it to master last week).

@HemangChothani HemangChothani changed the base branch from v2-staging to master August 28, 2020 09:43
@tseaver tseaver merged commit be98897 into googleapis:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants