Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asyncio system tests #132

Merged
merged 18 commits into from Jul 29, 2020

Conversation

rafilong
Copy link
Contributor

@rafilong rafilong commented Jul 28, 2020

Added system tests and removed Watch from interface. Opened issue to re-add Watch support at a later date #131.

Additionally, made fixes to improperly mocked return types in AsyncClient.list_documents and AsyncQuery.stream.

This PR is stacked on #123.

@rafilong rafilong added this to the AsyncIO Client milestone Jul 28, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2020
google/cloud/firestore_v1/__init__.py Show resolved Hide resolved
google/cloud/firestore_v1/async_client.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/async_collection.py Show resolved Hide resolved
tests/unit/v1/test_async_collection.py Show resolved Hide resolved
@rafilong rafilong requested a review from crwilcox July 28, 2020 21:38
tests/system/test_system_async.py Outdated Show resolved Hide resolved
tests/system/test_system_async.py Show resolved Hide resolved
tests/system/test_system_async.py Outdated Show resolved Hide resolved
@rafilong rafilong merged commit 4256a85 into googleapis:v2-staging Jul 29, 2020
@rafilong rafilong deleted the asyncio-system-tests branch July 29, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants