New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asyncio system tests #132
Merged
rafilong
merged 18 commits into
googleapis:v2-staging
from
rafilong:asyncio-system-tests
Jul 29, 2020
Merged
feat: asyncio system tests #132
rafilong
merged 18 commits into
googleapis:v2-staging
from
rafilong:asyncio-system-tests
Jul 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 28, 2020
rafilong
commented
Jul 28, 2020
rafilong
force-pushed
the
asyncio-system-tests
branch
from
July 28, 2020 20:51
d11d572
to
3cd740b
Compare
crwilcox
suggested changes
Jul 28, 2020
crwilcox
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added system tests and removed
Watch
from interface. Opened issue to re-addWatch
support at a later date #131.Additionally, made fixes to improperly mocked return types in
AsyncClient.list_documents
andAsyncQuery.stream
.This PR is stacked on #123.