Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asyncio microgen document #121

Merged
merged 8 commits into from Jul 22, 2020
Merged

feat: asyncio microgen document #121

merged 8 commits into from Jul 22, 2020

Conversation

rafilong
Copy link
Contributor

Resolves #77

@rafilong rafilong added this to the AsyncIO Client milestone Jul 21, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2020
BenWhitehead
BenWhitehead approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear to merge after #119 is merged and this is rebased

@rafilong rafilong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
tritone
tritone reviewed Jul 22, 2020
View reviewed changes
Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine to me here as well.

google/cloud/firestore_v1/async_document.py Show resolved Hide resolved
tritone
tritone reviewed Jul 22, 2020
View reviewed changes
Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing, much clearer now what is going on. This looks good!

One last question-- I see that some of these functions have very long docstrings which I'm assuming are mostly copied from the non-async code. Is any further modification required because of these changes?

@rafilong
Copy link
Contributor Author

Nice catch, for the most part the docstrings were good, but there was one function that I overlooked during my refactor.

@rafilong rafilong merged commit 31faecb into googleapis:v2-staging Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@tritone tritone tritone approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
AsyncIO Client
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafilong @BenWhitehead @tritone @yoshi-kokoro