Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: asyncio microgen client #118

Merged
merged 10 commits into from Jul 22, 2020

Conversation

rafilong
Copy link
Contributor

Resolves #73

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@rafilong rafilong added this to the AsyncIO Client milestone Jul 21, 2020
Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, a couple questions. Do you have system tests running yet which exercise the async microgen code path?

google/cloud/firestore_v1/async_client.py Show resolved Hide resolved
tests/unit/v1/test__helpers.py Show resolved Hide resolved
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after addressing @tritone's questions.

@rafilong
Copy link
Contributor Author

@tritone Unfortunately system tests do not exist yet - I was waiting to complete integration of the client before writing system tests, as I feel as though they are dependent on the entire client being converted to async, and it would be preferable to wait until that point. As this code is being committed to v2-staging rather than master, I feel like this is a reasonable choice.

@tritone
Copy link

tritone commented Jul 22, 2020

@tritone Unfortunately system tests do not exist yet - I was waiting to complete integration of the client before writing system tests, as I feel as though they are dependent on the entire client being converted to async, and it would be preferable to wait until that point. As this code is being committed to v2-staging rather than master, I feel like this is a reasonable choice.

Discussed offline, I'm okay with merging this code into the branch before system tests are added.

@rafilong rafilong merged commit de4cc44 into googleapis:v2-staging Jul 22, 2020
@rafilong rafilong deleted the asyncio-microgen-client branch July 22, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants