Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use DatetimeWithNanoseconds throughout library #116

Merged
merged 5 commits into from Jul 24, 2020
Merged

feat: use DatetimeWithNanoseconds throughout library #116

merged 5 commits into from Jul 24, 2020

Conversation

crwilcox
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
@crwilcox crwilcox added this to the v2 milestone Jul 17, 2020
@crwilcox crwilcox requested a review from rafilong July 17, 2020 01:39
rafilong
rafilong approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@rafilong rafilong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like there are a couple unused imports that are causing lint to fail, but otherwise good!

tests/unit/v1/test_base_document.py Outdated
@@ -17,6 +17,8 @@
import mock
import datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused.

@crwilcox crwilcox merged commit 1801ba2 into googleapis:v2-staging Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafilong rafilong rafilong approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crwilcox @rafilong