Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception when grpc is disabled #190

Merged
merged 5 commits into from Oct 11, 2021
Merged

fix: exception when grpc is disabled #190

merged 5 commits into from Oct 11, 2021

Conversation

daniel-sanche
Copy link
Contributor

Fixes #135

The library was crashing when grpc was disabled. Initializing logging client using keyword arguments instead of positional ones fixes this

I also added a test to prevent these issues in the future

@daniel-sanche daniel-sanche requested review from a team as code owners October 8, 2021 19:32
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. label Oct 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minherz
Copy link

minherz commented Oct 9, 2021

Question: Should we test this behavior for libraries in other languages?

@daniel-sanche
Copy link
Contributor Author

Question: Should we test this behavior for libraries in other languages?

Yes, this would be a good test to add for other languages as well

@daniel-sanche daniel-sanche merged commit 929e293 into main Oct 11, 2021
@daniel-sanche daniel-sanche deleted the fix-grpc branch October 11, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/python-error-reporting API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporting fails when GRPC is disabled
3 participants