Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a py.typed file for submodule #125

Open
crwilcox opened this issue Oct 12, 2021 · 1 comment
Open

Add a py.typed file for submodule #125

crwilcox opened this issue Oct 12, 2021 · 1 comment
Assignees
@busunkim96
Labels
api: dns Issues related to the googleapis/python-dns API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@crwilcox
Copy link
Contributor

To be in accordance with PEP 561 we should add a py.typed file to google/cloud/dns/py.typed

The file can be empty but does need to be present for some type checkers.
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/python-dns API. label Oct 12, 2021
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 13, 2021
@busunkim96 busunkim96 self-assigned this Oct 13, 2021
@crwilcox
Copy link
Contributor Author

Do note, you may need to run mypy, pyright, pytype against our samples before merging. It will ensure that we aren't exposing users to failing type checks.

Ideally we would add this to CI as well, to avoid future breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
api: dns Issues related to the googleapis/python-dns API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crwilcox @busunkim96