Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

docs(samples): add set agent code sample #370

Merged
merged 33 commits into from Sep 8, 2021
Merged

docs(samples): add set agent code sample #370

merged 33 commits into from Sep 8, 2021

Conversation

galz10
Copy link
Contributor

@galz10 galz10 commented Aug 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galz10 galz10 requested a review from a team as a code owner August 19, 2021 03:17
@galz10 galz10 requested a review from tmatsuo August 19, 2021 03:17
@snippet-bot
Copy link

snippet-bot bot commented Aug 19, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Aug 19, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2021
@galz10 galz10 changed the title Create agent docs(samples): add set agent code sample Aug 19, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 19, 2021
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2021
samples/snippets/set_agent.py Outdated Show resolved Hide resolved
samples/snippets/set_agent_test.py Outdated Show resolved Hide resolved
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2021
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2021
@galz10 galz10 requested a review from tmatsuo August 31, 2021 21:51
@galz10 galz10 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2021


def test_set_agent():
with pytest.raises(InvalidArgument):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The test code might confuse the readers. Maybe you can add a comment justifying the compromising test strategy.

@galz10 galz10 merged commit f997336 into googleapis:main Sep 8, 2021
@galz10 galz10 deleted the create-agent branch September 8, 2021 16:03
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/python-dialogflow API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants