Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

docs: fix typos #347

Merged
merged 1 commit into from Jul 25, 2021
Merged

docs: fix typos #347

merged 1 commit into from Jul 25, 2021

Conversation

slowy07
Copy link
Contributor

@slowy07 slowy07 commented Jul 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #346 馃

@slowy07 slowy07 requested review from a team as code owners July 25, 2021 01:44
@slowy07 slowy07 requested review from dandhlee and removed request for a team July 25, 2021 01:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2021
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Jul 25, 2021
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2021
dandhlee
dandhlee reviewed Jul 25, 2021
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @parthea this looks like another set of generated files, could you file a CL for the corresponding changes?

@dandhlee dandhlee requested a review from parthea July 25, 2021 05:30
@slowy07
Copy link
Contributor Author

slowy07 commented Jul 25, 2021 •
edited

LGTM, @parthea this looks like another set of generated files, could you file a CL for the corresponding changes?

maybe there is still a writing error or something, would you like to see it again sir? @dandhlee,
I'm afraid if there are still mistakes in writing or spelling, now i check again 馃槀

@dandhlee
Copy link
Contributor

@slowy07 I don't see any spelling mistakes based on what you've submitted! :)

@slowy07
Copy link
Contributor Author

slowy07 commented Jul 25, 2021 •
edited

@slowy07 I don't see any spelling mistakes based on what you've submitted! :)

okay thanks sir @dandhlee 馃榾 !

@parthea
Copy link
Contributor

parthea commented Jul 25, 2021

Created PR googleapis/gapic-generator-python#962 and internal CLs (cl/386724394 and cl/386724394) to fix autogenerated code.

parthea
parthea approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slowy07!

@parthea parthea requested a review from dandhlee July 25, 2021 14:07
@parthea parthea assigned dandhlee and unassigned parthea and dandhlee Jul 25, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 25, 2021
@parthea parthea changed the title fix: fixing unused imported module and fixing codespelling comment docs: fixing unused imported module and fixing codespelling comment Jul 25, 2021
@parthea parthea changed the title docs: fixing unused imported module and fixing codespelling comment docs: fix typos Jul 25, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 25, 2021
@slowy07
Copy link
Contributor Author

slowy07 commented Jul 25, 2021

Thanks @slowy07!

your welcome sir @parthea !

@parthea parthea merged commit 1aa9a7a into googleapis:master Jul 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 26, 2021
@release-please
chore: release 2.7.1 (#349)
07703da 
馃 I have created a release \*beep\* \*boop\*
---
### [2.7.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.7.0...v2.7.1) (2021-07-26)


### Bug Fixes

* enable self signed jwt for grpc ([#345](https://www.github.com/googleapis/python-dialogflow/issues/345)) ([ae434ed](https://www.github.com/googleapis/python-dialogflow/commit/ae434edc46c5e9c3243b928674727ea91cdf0145))


### Documentation

* fix typos ([#347](https://www.github.com/googleapis/python-dialogflow/issues/347)) ([1aa9a7a](https://www.github.com/googleapis/python-dialogflow/commit/1aa9a7a67d2997d87735666ecdcc55c8f8442cdf))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@dandhlee dandhlee Awaiting requested review from dandhlee

Assignees
No one assigned
Labels
api: dialogflow Issues related to the googleapis/python-dialogflow API. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix : unused imported module and typo grammar
4 participants
@slowy07 @dandhlee @parthea @yoshi-kokoro