Update Intent Optional Field is not Optional

[nnegrey]

In the updateIntent method, the language_code is listed as optional, but if you try to call the library without passing in that argument you get it error that it is required.

https://github.com/googleapis/dialogflow-python-client-v2/blob/master/dialogflow_v2/gapic/intents_client.py#L518-L547

[busunkim96]

language_code is described as an optional field in the RPC API Reference as well

https://cloud.google.com/dialogflow/docs/reference/rpc/google.cloud.dialogflow.v2beta1#updateintentrequest

[czahedi]

Hi folks,

What's the plan here? Noah and Bu Sun, can you revisit this and all the related Dialogflow Python issues? If there's work to be done I'd love for us to get started on it since these are out of SLO. It's possible a recent regen has fixed this though.

Thanks!

[nnegrey]

It appears the v2 (not v2beta1) proto has been fixed with annotations:

Changed here: googleapis/googleapis@b7abb49#diff-3bd3ac95a9428fb7b5e51caee180b94f

https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/v2/intent.proto#L1015

But library doesn't seem to have those changes: https://github.com/googleapis/dialogflow-python-client-v2/blob/master/dialogflow_v2/gapic/intents_client.py#L544

Issue with the generator or micro-generator?

[busunkim96]

@nnegrey The updates aren't merged automatically into the library. Autosynth currently opens a PR when it notices a difference in a regeneration. I think https://github.com/googleapis/dialogflow-python-client-v2/pull/163/files has a change to make language_code required.

[nnegrey]

That PR is for the KnowledgeBases, where the issue is still on the UpdateIntents call.

[busunkim96]

@nnegrey Yep! But any proto changes that happened after that won't appear until that one gets merged. Alternatively you can close that one and wait for a new PR to appear.

[nnegrey]

Oh..... now I get it.

But the new annotations got updated in September from the date, does that mean the one above although from October is maybe older? (sorry confused again)

[busunkim96]

Hmm, it does look like there's a mismatch. 😭 I'm going to close the open synth PR to see if we get something new tomorrow. Dialogflow is using the old generator (gapic-generator).

[nnegrey]

Looks like an issue with the old generator. :(

[czahedi]

Bu Sun please keep us updated on what you find :)

[czahedi]

Hey folks, any update here?

[busunkim96]

It looks like Dialogflow has not been migrated to use the new proto annotations, so required/optional is determined by the GAPIC config. https://github.com/googleapis/googleapis/blob/2e23b8fbc45f5d9e200572ca662fe1271bcd6760/google/cloud/dialogflow/v2beta1/dialogflow_gapic.yaml#L838 line makes language_code required.

Opening a CL now to fix it.

[czahedi]

Hey Bu Sun, checking back in. Did that other CL you mentioned go through?

[busunkim96]

Closed by #175