Skip to content
This repository has been archived by the owner on Jan 6, 2024. It is now read-only.

docs(samples): add initial sample codes #13

Merged
merged 10 commits into from Sep 30, 2020
Merged

docs(samples): add initial sample codes #13

merged 10 commits into from Sep 30, 2020

Conversation

wuyuexin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #12 馃

@wuyuexin wuyuexin requested a review from a team as a code owner September 29, 2020 18:53
@wuyuexin wuyuexin requested review from kurtisvg and removed request for a team September 29, 2020 18:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
samples/snippets/detect_intent_stream.py Show resolved Hide resolved
samples/snippets/detect_intent_stream.py Outdated Show resolved Hide resolved
samples/snippets/detect_intent_stream.py Outdated Show resolved Hide resolved
samples/snippets/detect_intent_stream.py Outdated Show resolved Hide resolved
samples/snippets/detect_intent_stream_test.py Outdated Show resolved Hide resolved
wuyuexin and others added 4 commits September 29, 2020 15:03
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
samples/snippets/detect_intent_audio.py Outdated Show resolved Hide resolved
samples/snippets/detect_intent_audio.py Outdated Show resolved Hide resolved
samples/snippets/detect_intent_audio.py Show resolved Hide resolved
detect_intent_audio(agent, session_id, audio_file_path, language_code)


# [START dialogflow_detect_intent_audio]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This region tag should be above the run_sample function

@kurtisvg
Copy link

@busunkim96 I don't see any Kokoro tests running on this repo. Is that intentional?

@busunkim96
Copy link
Contributor

@kurtisvg Kokoro isn't running is because author is outside the org. I also need to add samples configs though. Opened 334490453.

@kurtisvg
Copy link

@kurtisvg Kokoro isn't running is because author is outside the org. I also need to add samples configs though. Opened 334490453.

That was specifically what I was referring too :)

wuyuexin and others added 3 commits September 29, 2020 18:33
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@product-auto-label product-auto-label bot added api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. samples Issues that are directly related to samples. labels Sep 30, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@kurtisvg
Copy link

@wuyuexin Let me know if you need help merging this.

@wuyuexin
Copy link
Contributor Author

@wuyuexin Let me know if you need help merging this.

Yes, I'm not familiar with the merging process. Is there anything I need to do?

@busunkim96
Copy link
Contributor

馃憢 There's a small tweak I want to make to the noxfile/noxfile_config. I'll merge it for you right after that @wuyuexin.

Side note, I think I'll have to add another PR template for samples that looks like the one in python-docs-samples.

@wuyuexin wuyuexin requested a review from a team as a code owner September 30, 2020 20:10
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b590308 into googleapis:master Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create sample codes
4 participants