Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename dbtime and dbdate dtypes to avoid future conflicts with pandas #32

Merged
merged 1 commit into from Oct 14, 2021
Merged

feat: rename dbtime and dbdate dtypes to avoid future conflicts with pandas #32

merged 1 commit into from Oct 14, 2021

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Oct 14, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #31 🦕

@tswast tswast requested a review from a team October 14, 2021 14:58
@tswast tswast requested review from a team as code owners October 14, 2021 14:58
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Oct 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
@tswast
Copy link
Collaborator Author

tswast commented Oct 14, 2021

3.10 failure is expected, as there are pandas wheels yet

@tswast tswast merged commit 50ea0f7 into main Oct 14, 2021
@tswast tswast deleted the issue31-db-prefix branch October 14, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use "db" prefix for dtypes
2 participants
@tswast @busunkim96