Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supply anonymous credentials under emulator #71

Merged
merged 2 commits into from Aug 14, 2020
Merged

feat: supply anonymous credentials under emulator #71

merged 2 commits into from Aug 14, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 13, 2020

See: #70.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2020
cguardia
cguardia approved these changes Aug 13, 2020
View reviewed changes
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

tests/system/test_system.py Outdated
credentials=client._credentials,
_http=client._http,
)
emulator_dataset = os.getenv(GCD_DATASET)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why we don't use the DATASTORE_DATASET defined above here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@tseaver tseaver merged commit 4db3c40 into master Aug 14, 2020
@tseaver tseaver deleted the 70-normalize-emulator-support branch August 14, 2020 17:55
@c4rlo c4rlo mentioned this pull request Aug 15, 2020
Closed
@tseaver tseaver mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cguardia cguardia cguardia approved these changes

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tseaver @cguardia