chore: ensure mypy passes for package

[crwilcox]

related #240

mypy google/cloud/datastore
Success: no issues found in 12 source files

mypy -p google.cloud.datastore --no-incremental
Success: no issues found in 12 source files

[tseaver]

Shouldn't we be adding a nox session for mypy?

[tseaver]

Why isn't this just a function?

Suggested change

	def no_datastore_api(self):
	return None
	make_datastore_api = no_datastore_api
	def make_datastore_api(self):
	return None

And maybe it should raise an exception, since the only reason we're here is that gRPC is disabled?

[crwilcox]

this would be a lambda but flake8 isn't a fan and I am not going to protest loudly about it. This is a minimal change that ensures make_datastore_api is consistently a callable.

[tseaver]

I just don't see the point in defining the no_datastore_api function, only to alias it as make_datastore_api -- just name the function make_datastore_api.

[crwilcox]

I get it, but if you do that you end up fighting with google/cloud/datastore/client.py:41: error: All conditional function variants must have identical signatures :\ This seems not terrible?

[tseaver]

I pushed d6b600a, which passes mypy, and removes the extra no_database_api function.

[crwilcox]

This can merge, but bug should have a comment added that we want to evaluate mypy against google and tests (comment in code)

This PR needs to merge to remove a class of errors from generated code https://www.github.com/googleapis/gapic-generator-python/issues/1026

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tseaver]

@googlebot I consent.