Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Code Coverage seems to have decreased with a recent gen change #109

Closed
crwilcox opened this issue Oct 30, 2020 · 3 comments
Closed

Generated Code Coverage seems to have decreased with a recent gen change #109

crwilcox opened this issue Oct 30, 2020 · 3 comments
Labels
api: datastore Issues related to the googleapis/python-datastore API. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

Upon regenerating, code coverage went from 99% to 97%.

#108

nox > coverage report --show-missing --fail-under=99
Name                                                                                  Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------------
google/cloud/datastore/__init__.py                                                        9      0      0      0   100%
google/cloud/datastore/_app_engine_key_pb2.py                                            23      0      2      0   100%
google/cloud/datastore/_gapic.py                                                         15      0      2      0   100%
google/cloud/datastore/_http.py                                                          45      0      2      0   100%
google/cloud/datastore/batch.py                                                         106      0     32      0   100%
google/cloud/datastore/client.py                                                        228      0    116      0   100%
google/cloud/datastore/entity.py                                                         23      0      6      0   100%
google/cloud/datastore/helpers.py                                                       207      0    132      0   100%
google/cloud/datastore/key.py                                                           201      0     74      0   100%
google/cloud/datastore/query.py                                                         202      3     64      1    98%   588->596, 596-598
google/cloud/datastore/transaction.py                                                    50      0     10      0   100%
google/cloud/datastore/version.py                                                         1      0      0      0   100%
google/cloud/datastore_admin_v1/services/__init__.py                                      0      0      0      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/__init__.py                      3      0      0      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/async_client.py                 90     41     20      0    45%   294-338, 435-477, 506-528, 565-593
google/cloud/datastore_admin_v1/services/datastore_admin/client.py                      178      0     58      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/pagers.py                       42     15     10      0    60%   124-127, 130, 134-138, 141-146
google/cloud/datastore_admin_v1/services/datastore_admin/transports/__init__.py           9      0      0      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/transports/base.py              46      0      8      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc.py              71      0     20      0   100%
google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc_asyncio.py      74      0     20      0   100%
google/cloud/datastore_admin_v1/types/__init__.py                                         3      0      0      0   100%
google/cloud/datastore_admin_v1/types/datastore_admin.py                                 74      0      0      0   100%
google/cloud/datastore_admin_v1/types/index.py                                           27      0      0      0   100%
google/cloud/datastore_v1/services/__init__.py                                            0      0      0      0   100%
google/cloud/datastore_v1/services/datastore/__init__.py                                  3      0      0      0   100%
google/cloud/datastore_v1/services/datastore/async_client.py                            123     75     40      0    29%   88, 192-232, 263-285, 324-351, 426-460, 508-537, 586-616, 664-702
google/cloud/datastore_v1/services/datastore/client.py                                  214      0     84      0   100%
google/cloud/datastore_v1/services/datastore/transports/__init__.py                       9      0      0      0   100%
google/cloud/datastore_v1/services/datastore/transports/base.py                          49      0      8      0   100%
google/cloud/datastore_v1/services/datastore/transports/grpc.py                          78      0     24      0   100%
google/cloud/datastore_v1/services/datastore/transports/grpc_asyncio.py                  81      0     24      0   100%
google/cloud/datastore_v1/types/__init__.py                                               4      0      0      0   100%
google/cloud/datastore_v1/types/datastore.py                                             76      0      0      0   100%
google/cloud/datastore_v1/types/entity.py                                                35      0      0      0   100%
google/cloud/datastore_v1/types/query.py                                                 80      0      0      0   100%
tests/unit/__init__.py                                                                    0      0      0      0   100%
tests/unit/test__gapic.py                                                                32      0      2      0   100%
tests/unit/test__http.py                                                                461      0      8      0   100%
tests/unit/test_batch.py                                                                378      0     12      0   100%
tests/unit/test_client.py                                                               990      0     54      0   100%
tests/unit/test_entity.py                                                               167      0      0      0   100%
tests/unit/test_helpers.py                                                              754      0     14      0   100%
tests/unit/test_key.py                                                                  531      0      4      0   100%
tests/unit/test_query.py                                                                549      0     20      0   100%
tests/unit/test_transaction.py                                                          257      0      4      0   100%
---------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                  6598    134    874      1    97%
Coverage failure: total of 97 is less than fail-under=99
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Oct 30, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 31, 2020
@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 30, 2020
@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2020

@crwilcox We are also missing coverage in manual code for the fix in PR #18.

@tseaver
Copy link
Contributor

tseaver commented Apr 21, 2021

The micro-generator is not emitting coverage for API-invoking methods of the async clients, nor for any methods of the async pagers.

@tseaver
Copy link
Contributor

tseaver commented Jul 9, 2021

Now at 100%:

$ nox -re unit cover
nox > Running session unit-3.6
...
tests/unit/test_transaction.py                                                          276      0      6      0   100%
---------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                  8041      0    970      0   100%
nox > coverage erase
nox > Session cover was successful.
nox > Ran multiple sessions:
nox > * unit-3.6: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * cover: success

@tseaver tseaver closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-datastore API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tseaver @crwilcox @yoshi-automation