fix: normalize / test deprecation of 'Client.reserve_ids' #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@tseaver this hasn't been merged yet, curious if you think we should release a 1.9.1 with this so we can deprecate/simplify for 2.0? or if you think this is commonly used enough to justify deprecating in 2.0? |
|
@crwilcox Given that 2.0.0 is out already, I guess we just merge this and leave the deprecation in place until 3.0. |
|
@tseaver that seems reasonable to me. |
crwilcox
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
Closes #100