Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excess comma in reserve_ids breaks the function #100

Closed
Kazade opened this issue Oct 7, 2020 · 0 comments · Fixed by #103
Closed

Excess comma in reserve_ids breaks the function #100

Kazade opened this issue Oct 7, 2020 · 0 comments · Fixed by #103
Assignees
@tseaver
Labels
api: datastore Issues related to the googleapis/python-datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@Kazade
Copy link

Kazade commented Oct 7, 2020

See here: https://github.com/googleapis/python-datastore/blob/master/google/cloud/datastore/client.py#L888

This trailing comma makes message a tuple, and so the deprecation warning blows up with:

TypeError: expected string or bytes-like object

Environment details

  • OS type and version: Fedora 32
  • Python version: python 3.8.5
  • pip version: 20.2.3
  • google-cloud-datastore version: 1.15.1

Steps to reproduce

  1. Use reserve_ids in Python code
  2. World ends.

Stack trace

  vi +891  .venv/lib/python3.8/site-packages/google/cloud/datastore/client.py  # reserve_ids
    warnings.warn(message, DeprecationWarning)
TypeError: expected string or bytes-like object
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Oct 7, 2020
Kazade added a commit to Kazade/python-datastore that referenced this issue Oct 7, 2020
@Kazade
Remove trailing comma
4e6a692 
Fixes googleapis#100
@Kazade Kazade mentioned this issue Oct 7, 2020
Closed
4 tasks
tseaver added a commit that referenced this issue Oct 7, 2020
@tseaver
fix: normalize / test deprecation of 'Client.reserve_ids'
f1c9286 
Closes #101
Closes #100
@tseaver tseaver mentioned this issue Oct 7, 2020
Merged
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 8, 2020
tseaver added a commit that referenced this issue Nov 11, 2020
@tseaver @crwilcox
fix: normalize / test deprecation of 'Client.reserve_ids' (#103)
5851522 
Closes #101
Closes #100

Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: datastore Issues related to the googleapis/python-datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
3 participants
@Kazade @tseaver @yoshi-automation