docs(samples): add samples from docs & reorganize all samples for testing #78
Conversation
product-auto-label
bot
added
api: datacatalog
google-cla
bot
added
the
cla: yes
|
Here is the summary of changes. You are about to add 18 region tags.
You are about to delete 7 region tags.
This comment is generated by snippet-bot.
|
steffnay
changed the title
steffnay
added
the
kokoro:force-run
|
@steffnay snippet-bot thinks this PR will delete a region tag which is currently used. This means it will break devsite. Can you try to fix it? Let me know if it's a false positive. |
|
@tmatsuo I replaced the deleted tags. It now appears the bot doesn't recognize them as a valid prefix since they were created prior to that standard, I believe. |
|
@steffnay It seems like the region tag prefix for Data Catalog is
|
There was a problem hiding this comment.
The samples themselves look good, mostly my comments are my thinking about developer friction because this API has so many implicit dependencies between resources.
My other meta-comment is about the v1beta1 samples as a whole: can we simply remove them in favor of the GA endpoint?
|
@shollyman I'd like to remove the v1beta1 samples, but I was thinking I will wait to do that until the documentation on c.g.c is updated. |
There was a problem hiding this comment.
I added a couple of lil nits to the requirements and also wanted to check - these noxfiles aren't modified at all, correct? (if they are, your changes will be overwritten by owlbot at some point and you should add a noxfile_config to signal what's different from base noxfile)
🤖 I have created a release \*beep\* \*boop\* --- ### [3.4.1](https://www.github.com/googleapis/python-datacatalog/compare/v3.4.0...v3.4.1) (2021-09-01) ### Bug Fixes * make datacatalog == datacatalog_v1 ([#206](https://www.github.com/googleapis/python-datacatalog/issues/206)) ([aefe892](https://www.github.com/googleapis/python-datacatalog/commit/aefe892ab2cdb37b5f58faecd45758ea685c74ec)) ### Documentation * **samples:** add samples from docs & reorganize all samples for testing ([#78](https://www.github.com/googleapis/python-datacatalog/issues/78)) ([d34aca0](https://www.github.com/googleapis/python-datacatalog/commit/d34aca05a87aa75ad982612f57fe987a005f7896)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Adds samples from cloud.google.com documentation.
Updates samples.
Adds tests.
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
🦕