fix: make datacatalog == datacatalog_v1 #206
Conversation
Hmm the failing samples seem to be v1beta1, which shouldn't be impacted by this change. I see a mix of failures and passes on these tests on continuous builds on 8/12 and 8/13. Weirdly no periodic builds have failed. |
@busunkim96 The periodic builds roll back to run against the last released version of the repo, and the samples were added in PR #78, which landed after the |
I just ran the
This patch gets the --- a/samples/v1beta1/conftest.py
+++ b/samples/v1beta1/conftest.py
@@ -86,9 +86,16 @@ def entry(client, entry_group_name):
now.strftime("%Y%m%d%H%M%S"), uuid.uuid4().hex[:8]
)
entry = datacatalog_v1beta1.CreateEntryRequest
- entry = client.create_entry(
- request={"parent": entry_group_name, "entry_id": random_entry_id, "entry": {"type_": "DATA_STREAM", "name": "samples_test_entry"}}
- )
+ request = {
+ "parent": entry_group_name,
+ "entry_id": random_entry_id,
+ "entry": {
+ "type_": "DATA_STREAM",
+ "user_specified_system": "sample_system",
+ "name": "samples_test_entry",
+ },
+ }
+ entry = client.create_entry(request=request)
yield entry.name
client.delete_entry(request={"name": entry.name})
|
@tseaver Ah I forgot about the rolling back bit... The failures for the various Python versions didn't happen at the same time strangely, the 3.7 continuous failed this morning, but 3.6 and 3.8 passed. 🤷♀️ @steffnay do you know of any recent changes to the Datacatalog v1beta1 surface? |
After searching around internally I found internal changelist 387097607, which supposed to fix bug 194281199. Explanation provided is the bug:
It sounds to me like allowing an entry of that type without |
🤖 I have created a release \*beep\* \*boop\* --- ### [3.4.1](https://www.github.com/googleapis/python-datacatalog/compare/v3.4.0...v3.4.1) (2021-09-01) ### Bug Fixes * make datacatalog == datacatalog_v1 ([#206](https://www.github.com/googleapis/python-datacatalog/issues/206)) ([aefe892](https://www.github.com/googleapis/python-datacatalog/commit/aefe892ab2cdb37b5f58faecd45758ea685c74ec)) ### Documentation * **samples:** add samples from docs & reorganize all samples for testing ([#78](https://www.github.com/googleapis/python-datacatalog/issues/78)) ([d34aca0](https://www.github.com/googleapis/python-datacatalog/commit/d34aca05a87aa75ad982612f57fe987a005f7896)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #116
I have verified that v1beta1 -> v1 is additive, so this is not
a breaking change. See internal changelist 390485345 for the proto
level diff and successful run through the proto brekaing change detector