Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Missing ability to set taints, tags and labels of nodepool #140

Closed
samos123 opened this issue Aug 24, 2021 · 4 comments · Fixed by #147
Closed

Missing ability to set taints, tags and labels of nodepool #140

samos123 opened this issue Aug 24, 2021 · 4 comments · Fixed by #147
Assignees
Labels
api: container Issues related to the googleapis/python-container API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@samos123
Copy link

samos123 commented Aug 24, 2021

GKE container NodePool update API supports updating the taints however looks like this python library does not support this yet.

See here for more info: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters.nodePools/update

The set_labels function that exists is for applying them at a cluster level, however we need them at the nodepool level.

@product-auto-label product-auto-label bot added the api: container Issues related to the googleapis/python-container API. label Aug 24, 2021
@rashisht1
Copy link

rashisht1 commented Aug 24, 2021

Additionally, the ability to update labels, tags and gvnic is also missing in the python library.

@samos123 samos123 changed the title Missing ability to set taints of nodepool Missing ability to set taints, tags and labels of nodepool Aug 24, 2021
@bourgeoisor bourgeoisor added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 24, 2021
@bourgeoisor
Copy link
Contributor

Looks like the proto hasn't been updated yet. Investigating.

@bourgeoisor
Copy link
Contributor

I can confirm there is some discrepancy internally, thank you for bringing this up! I will update this issue once it is fixed.

@bourgeoisor bourgeoisor self-assigned this Sep 8, 2021
@bourgeoisor
Copy link
Contributor

The upstream proto has been updated with taints, tags, labels, gvnic: https://github.com/googleapis/googleapis/blob/master/google/container/v1beta1/cluster_service.proto#L2196-L2209

Waiting for this PR to go through: #147

gcf-merge-on-green bot pushed a commit that referenced this issue Sep 23, 2021
Closes #140

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 396762326

Source-Link: googleapis/googleapis@1f1d09d

Source-Link: googleapis/googleapis-gen@4bed2d4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGJlZDJkNDZhNWU1YTZkNTM3ZWJjMTUxMTVjZmU0Y2NlNWZjMDQwNSJ9

feat: added node pool level network config
feat: added update support for node pool labels, taints and network tags
feat: added configuration for workload certificates and identity service component 
feat: added configuration for node pool defaults, autopilot, logging and monitoring
feat: added the option to specify L4 load balancer configuration and IP v6 configuration 
feat: added the option to list supported windows versions 
fix: deprecated KALM addon config option 
fix: deprecated cluster status condition code 
docs: clarified SetNodePoolSize API behavior
fix(deps): require proto-plus 1.15.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: container Issues related to the googleapis/python-container API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants