Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Adding pagination sample. #78

Merged
merged 22 commits into from Aug 10, 2021
Merged

docs(samples): Adding pagination sample. #78

merged 22 commits into from Aug 10, 2021

Conversation

m-strzelczyk
Copy link
Contributor

Adding samples to demonstrate how pagination works in this library.

@product-auto-label product-auto-label bot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jul 15, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jul 19, 2021 •
edited

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@m-strzelczyk m-strzelczyk mentioned this pull request Jul 19, 2021
Closed
@m-strzelczyk
Copy link
Contributor Author

m-strzelczyk commented Jul 19, 2021 •
edited

This tests will work once #79 is resolved. Waiting on #80

@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 19, 2021 15:05
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 19, 2021 15:05
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 23, 2021 11:23
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 23, 2021 11:23
@m-strzelczyk m-strzelczyk added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 23, 2021
@m-strzelczyk
Copy link
Contributor Author

@leahecole could you have a look?

@parthea
Copy link
Contributor

parthea commented Aug 2, 2021

@m-strzelczyk, I see that a delay was added here possibly for working with eventual consistency. I hit a similar issue In python-monitoring and I added a retry to reduce the flakiness.

@m-strzelczyk
Copy link
Contributor Author

@m-strzelczyk, I see that a delay was added here possibly for working with eventual consistency. I hit a similar issue In python-monitoring and I added a retry to reduce the flakiness.

Thanks, I'll see how to apply this to those tests, they are really irritating :P

@m-strzelczyk m-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2021
@m-strzelczyk
Copy link
Contributor Author

OK, the sleeps seem to have solved the problem with those tests. @leahecole can you review?

@parthea parthea changed the title feat: Adding pagination sample. docs(samples): Adding pagination sample. Aug 4, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2021
@m-strzelczyk
Copy link
Contributor Author

@parthea can you perhaps give a review? I'd love to get this merged this week :P

dandhlee
dandhlee reviewed Aug 6, 2021
View reviewed changes
samples/snippets/sample_pagination.py Outdated Show resolved Hide resolved
samples/snippets/sample_pagination.py Outdated Show resolved Hide resolved
samples/snippets/quickstart.py Outdated Show resolved Hide resolved
samples/snippets/test_sample_pagination.py Show resolved Hide resolved
samples/snippets/quickstart.py Show resolved Hide resolved
@m-strzelczyk @dandhlee
Apply suggestions from code review
16f39a6 
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
dandhlee
dandhlee approved these changes Aug 10, 2021
View reviewed changes
samples/snippets/quickstart.py Show resolved Hide resolved
samples/snippets/test_sample_pagination.py Show resolved Hide resolved
@FrodoTheTrue FrodoTheTrue merged commit db0404c into master Aug 10, 2021
@FrodoTheTrue FrodoTheTrue deleted the compute-pagination branch August 10, 2021 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xmasreturns Xmasreturns Xmasreturns left review comments

@dandhlee dandhlee dandhlee approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@m-strzelczyk @parthea @Xmasreturns @dandhlee @FrodoTheTrue @yoshi-kokoro