Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat: adding samples to start/stop/reset operations #75

Merged
merged 13 commits into from Aug 4, 2021

Conversation

m-strzelczyk
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

b/192839790

Will be added to this page

@snippet-bot
Copy link

snippet-bot bot commented Jul 12, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jul 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2021
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2021
@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 20, 2021 08:52
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 20, 2021 08:52
@m-strzelczyk m-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczyk m-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczyk m-strzelczyk requested review from a team as code owners July 22, 2021 13:51
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2021
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2021
@m-strzelczyk m-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@m-strzelczyk
Copy link
Contributor Author

@engelke can you have a look?

@m-strzelczyk m-strzelczyk added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2021
@m-strzelczyk
Copy link
Contributor Author

The tests should be finally fixed now. @engelke can you review?

Copy link

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-strzelczyk m-strzelczyk merged commit 0df87a9 into master Aug 4, 2021
@m-strzelczyk m-strzelczyk deleted the samples-start-stop branch August 4, 2021 10:14
@parthea parthea mentioned this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants