This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
feat: Switch to string enums for compute (#685) #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml) Source-Link: googleapis/googleapis@8ce4ea6 Source-Link: googleapis/googleapis-gen@55e242c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9
google-cla
bot
added
the
cla: yes
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
the
api: compute
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
…//github.com/googleapis/python-compute into owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
added
the
do not merge
parthea
suggested changes
Nov 19, 2021
gcf-owl-bot
bot
requested review from
m-strzelczyk and
a team
as code owners
parthea
removed
the
do not merge
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
force-pushed
the
owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0
branch
from
185428e
to
65911eb
Compare
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
force-pushed
the
owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0
branch
from
65911eb
to
8e9d5c5
Compare
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
|
@m-strzelczyk Please could you review/approve? |
m-strzelczyk
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts).
Also cleanup regenerate other files (grpc_service_config and service yaml)
Source-Link: googleapis/googleapis@8ce4ea6
Source-Link: https://github.com/googleapis/googleapis-gen/commit/55e242c7cf5e600fabb8d767bd06f4fdfad6a015
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9