Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Python 3.9, drop support for Python 3.5 #55

Merged
merged 2 commits into from Dec 12, 2020
Merged

feat: add support for Python 3.9, drop support for Python 3.5 #55

merged 2 commits into from Dec 12, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 11, 2020

No description provided.

@tseaver tseaver requested a review from a team as a code owner December 11, 2020 20:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@tseaver tseaver changed the title feat: add support for Python 3.9 feat: add support for Python 3.9, drop support for Python 3.5 Dec 11, 2020
crwilcox
crwilcox reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",

I am guessing this is staying this way to not mix the core/api-core dep reqs?

@tseaver
Copy link
Contributor Author

tseaver commented Dec 12, 2020

@crwilcox

python_requires=">=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*",

I am guessing this is staying this way to not mix the core/api-core dep reqs?

We should probably update both of them and plan on releasing them in close proximity.

@tseaver tseaver mentioned this pull request Dec 12, 2020
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Dec 12, 2020

See: googleapis/python-api-core#114

Also, we should likely tweak the pin on google-api-core to match.

@tseaver tseaver merged commit ddf7ce5 into master Dec 12, 2020
@tseaver tseaver deleted the add-py39-support branch December 12, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@tswast tswast Awaiting requested review from tswast

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tseaver @crwilcox