This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
fix: disable self signed jwt if users provide their own credential #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudchannel
google-cla
bot
added
the
cla: yes
parthea
approved these changes
Aug 31, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.3](https://www.github.com/googleapis/python-channel/compare/v1.2.2...v1.2.3) (2021-08-31) ### Bug Fixes * disable self signed jwt if users provide their own credential ([#86](https://www.github.com/googleapis/python-channel/issues/86)) ([d7c07f8](https://www.github.com/googleapis/python-channel/commit/d7c07f8d579ce55ea86520e6a7b7a268befae92d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
added a commit
that referenced
this pull request
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self signed jwt doesn't work for non-prod endpoint, and the workaround is let the customer pass in their own credential to disable self signed jwt, see googleapis/python-aiplatform#553 (comment). However the workaround doesn't work as expected, and this PR fixes the issue.
related PR in gapic-generator-python.
fixes b/197117709