Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

fix: correct link to docs #5

Merged
merged 3 commits into from Mar 10, 2020
Merged

fix: correct link to docs #5

merged 3 commits into from Mar 10, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Feb 29, 2020 •
edited by plamut

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #8 馃

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 29, 2020
@busunkim96 busunkim96 mentioned this pull request Mar 10, 2020
Closed
@plamut plamut added the type: docs Improvement to the documentation for an API. label Mar 10, 2020
plamut
plamut reviewed Mar 10, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@busunkim96 busunkim96 requested a review from plamut March 10, 2020 17:45
plamut
plamut approved these changes Mar 10, 2020
View reviewed changes
Copy link

@plamut plamut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, the new wording on the README is not ambiguous/misleading anymore. 馃憤

@busunkim96 busunkim96 merged commit 3d87965 into master Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@plamut plamut plamut approved these changes

@leahecole leahecole Awaiting requested review from leahecole

@software-dov software-dov Awaiting requested review from software-dov

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The client library link is broken
3 participants
@busunkim96 @plamut @googlebot