Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider DeadlineExceeded error #901

Open
daniel-sanche opened this issue Dec 13, 2023 · 0 comments
Open

Reconsider DeadlineExceeded error #901

daniel-sanche opened this issue Dec 13, 2023 · 0 comments
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v3-GA

Comments

@daniel-sanche
Copy link
Contributor

Currently, we raise DeadlineExceeded if the overall operation times out, with the retries exposed as a RetryExceptionGroup attached.

Is this the right long-term decision for GA? This is a bit custom, and not how other GCP libraries handle this

Maybe a better solution would be to make a separate OperationTimeout exception, completely separate from the grpc deadline error. We can make it a subclass of RetryError in api_core, and make all libraries align on this

see googleapis/python-api-core#573
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 13, 2023
@daniel-sanche daniel-sanche added this to the v3-GA milestone Dec 13, 2023
@daniel-sanche daniel-sanche self-assigned this Dec 13, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 13, 2023
@daniel-sanche daniel-sanche mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v3-GA
Development

No branches or pull requests
1 participant
@daniel-sanche