Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): filter cpu query to get metrics for the correct resources #81

Merged
merged 2 commits into from Aug 4, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jul 31, 2020

Transferring one commit that was left behind in python-docs-samples. Replaces #71


#4237 BT metricscaler - Filter cpu query to get the metrics for the correct resources (#4238)

  • #4237 Added a filter to the cpu & storage queries to get the metrics for the correct resources

…orrect resources [(#4238)](GoogleCloudPlatform/python-docs-samples#4238)

* #4237 Added a filter to the cpu & storage queries to get the metrics for the correct resources

* fix lint

* fix lint again

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Co-authored-by: Leah Cole <coleleah@google.com>
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 4, 2020
@busunkim96
Copy link
Contributor Author

Hammer merging, main Kokoro test is failing on "quota exceeded".

@busunkim96 busunkim96 merged commit 2c8c386 into master Aug 4, 2020
@busunkim96 busunkim96 deleted the add-samples-commit branch August 4, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants