Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigtable): remove missing argument from instance declaration #47

Merged
merged 3 commits into from Jun 9, 2020

Conversation

rafilong
Copy link
Contributor

@rafilong rafilong commented Jun 1, 2020

Fixes #42 馃

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 1, 2020
@rafilong rafilong requested a review from crwilcox June 1, 2020 16:41
@rafilong rafilong changed the title docs: remove missing argument from instance declaration docs(bigtable): remove missing argument from instance declaration Jun 1, 2020
@rafilong
Copy link
Contributor Author

rafilong commented Jun 1, 2020

Now that location is specified in the cluster, is it worth mentioning this in the documentation about creating an instance or is this something that users can/should discover later?

@rafilong rafilong added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 2, 2020
@rafilong rafilong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@rafilong rafilong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@rafilong rafilong added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c966647 into googleapis:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Fix outdated Instance declaration
5 participants